Merged
Conversation
b3da5c1 to
8206952
Compare
joowojr
requested changes
Jan 23, 2025
Contributor
There was a problem hiding this comment.
mapper에서는 필드의 매핑 기능 정도만 수행하고, 비즈니스 로직은 도메인 레이어로 옮겨야할거 같습니다!
Contributor
There was a problem hiding this comment.
같은 dto 형식이라도 dto는 API마다 분리해주시면 좋을것 같습니다!
joowojr
requested changes
Jan 23, 2025
Contributor
There was a problem hiding this comment.
검색 및 필터링의 경우는 Search, Filter, 단순 조회의 경우 Get 등의 네이밍이 좋을 것 같습니다!
Collaborator
Author
There was a problem hiding this comment.
108번 브랜치에서 반영하겠습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 요약(Summary)
✍🏼 상세(More)
PR Desciption
Requirements for Reviewer
PR Log
새롭게 배운 것
고민 중인 사항
첨부 자료
Requirements for Reviewer
✅ 체크리스트(Checklist)
🚪 이슈 번호(Issue numbers)
Closes #15